-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix #26233: Combination of pickup measure and linked staff makes scor… #27694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
So this PR fixes the issue by deleting those default rests during the clone process. But I was wondering: maybe those default rests should never have been created, if the first thing that will happen to them is that they are deleted. I suspect they are created when inserting the staff into the score, so before |
I understand that. I have a question: Would you like this to be for every case where a staff member is cloned AND linked? I think the problem is that the functions being used are also what create default staffs, and I'm unsure how to introduce the condition whether or not to remove rests upon default initialization based on the actual time signature. This is my reasoning behind why I did it the way I did. If you have a better suggestion, I can try to implement it, but I can also try my best to do it on my own. However, I did consider this option from your original suggestion, but I couldn't figure out a way to compartmentalize and keep the two scenarios separate. |
|
@skalra4 Something went wrong while rebasing. It looks like you first rebased, then pulled the unrebased version from your fork on GitHub, and then pushed. Instead, you should rebase, and then force-push. So:
|
e217c12
to
c99db42
Compare
…akes score corrupted
c99db42
to
50ea827
Compare
I apologize for the messy working tree. Git still gets me, especially on big projects with many branches and changes. |
No worries. It looks correct now! |
Co-authored-by: Casper Jeukendrup <[email protected]>
Great. Thanks so much for all the help. I appreciate and like the MuseScore dev community a lot! |
…e corrupted
Resolves: #26233
Case for pickup measures with linked staves. If you switch the order of ascending rests, there may be an empty segment due to the longer rest/note, which was not being copied to the linked staff, which when created used the default staff configuration, causing a rest or note to be left behind, seemingly "creating a duplicate" and corrupting the score.